update electron to v40, update node versions in workflows#4018
update electron to v40, update node versions in workflows#4018sdetweil merged 6 commits intoMagicMirrorOrg:developfrom
Conversation
|
I now used the config from the first failed test with and starting mm with [2026-01-22 19:36:18.602] [LOG] [electron] Launching application.
[2026-01-22 19:36:18.605] [INFO] [systeminformation]
#### System Information ####
- SYSTEM: manufacturer: Microsoft; model: Docker Container; virtual: true; MM: v2.35.0-develop
- OS: platform: linux; distro: Debian GNU/Linux; release: 13; arch: x64; kernel: 6.6.87.2-microsoft-standard-WSL2
- VERSIONS: electron: 40.0.0; used node: 25.4.0; installed node: 25.4.0; npm: 11.7.0; pm2:
- ENV: XDG_SESSION_TYPE: undefined; MM_CONFIG_FILE: tests/configs/modules/calendar/custom.js
WAYLAND_DISPLAY: wayland-0; DISPLAY: unix:0.0; ELECTRON_ENABLE_GPU: undefined
- RAM: total: 14872.19 MB; free: 13132.63 MB; used: 1739.56 MB
- OTHERS: uptime: 211 minutes; timeZone: UTC
[2026-01-22 19:36:18.902] [LOG] [calendar] Create new calendarfetcher for url: http://localhost:8080/tests/mocks/calendar_test_icons.ics - Interval: 3600000
[2026-01-22 19:36:18.946] [ERROR] [calendar] http://localhost:8080/tests/mocks/calendar_test_icons.ics - iCal parsing failed: Temporal error: Must specify time zone.
[2026-01-22 19:36:18.950] [ERROR] [calendar] Calendar Error. Could not fetch calendar: http://localhost:8080/tests/mocks/calendar_test_icons.ics TypeError: Temporal error: Must specify time zone.
at ZonedDateTime.until (<anonymous>)
at _RRuleTemporal.between (/opt/magic_mirror/node_modules/rrule-temporal/dist/index.cjs:1529:41)
at RRuleCompatWrapper.between (/opt/magic_mirror/node_modules/node-ical/ical.js:73:33)
at Object.getMomentsFromRecurringEvent (/opt/magic_mirror/__modules/default/calendar/calendarfetcherutils.js:69:22)
at Object.expandRecurringEvent (/opt/magic_mirror/__modules/default/calendar/calendarfetcherutils.js:302:40)
at /opt/magic_mirror/__modules/default/calendar/calendarfetcherutils.js:159:39
at Array.forEach (<anonymous>)
at Object.filterEvents (/opt/magic_mirror/__modules/default/calendar/calendarfetcherutils.js:107:24)
at CalendarFetcher.fetchCalendar (/opt/magic_mirror/__modules/default/calendar/calendarfetcher.js:168:41)
at process.processTicksAndRejections (node:internal/process/task_queues:103:5)So the new electron version causes errors in ical parsing??? |
|
That's interesting. I'll see if I can find out anything. |
|
When I run the same setup without electron it works ( I compared the 2 node@bd2930cf8500:/opt/magic_mirror$ diff lock.39 lock.40
65c65
< "electron": "^39.3.0"
---
> "electron": "^40.0.0"
4751,4753c4751,4753
< "version": "39.3.0",
< "resolved": "https://registry.npmjs.org/electron/-/electron-39.3.0.tgz",
< "integrity": "sha512-ZA2Cmu5Vs8zeuZBr71XWZ5vgm7lRDB9N50oV6ee7YocITyxRxx/apWFKY48Sxyn0gzVlX+6YQc3CS1PtYIkGUg==",
---
> "version": "40.0.0",
> "resolved": "https://registry.npmjs.org/electron/-/electron-40.0.0.tgz",
> "integrity": "sha512-UyBy5yJ0/wm4gNugCtNPjvddjAknMTuXR2aCHioXicH7aKRKGDBPp4xqTEi/doVcB3R+MN3wfU9o8d/9pwgK2A==",
4759c4759
< "@types/node": "^22.7.7",
---
> "@types/node": "^24.9.0",
4768,4784d4767
< },
< "node_modules/electron/node_modules/@types/node": {
< "version": "22.19.7",
< "resolved": "https://registry.npmjs.org/@types/node/-/node-22.19.7.tgz",
< "integrity": "sha512-MciR4AKGHWl7xwxkBa6xUGxQJ4VBOmPTF7sL+iGzuahOFaO0jHCsuEfS80pan1ef4gWId1oWOweIhrDEYLuaOw==",
< "license": "MIT",
< "optional": true,
< "dependencies": {
< "undici-types": "~6.21.0"
< }
< },
< "node_modules/electron/node_modules/undici-types": {
< "version": "6.21.0",
< "resolved": "https://registry.npmjs.org/undici-types/-/undici-types-6.21.0.tgz",
< "integrity": "sha512-iwDZqg0QAGrg9Rav5H4n0M64c3mkR59cJ6wQp+7C4nI0gsmExaedaYLNO44eT4AtBBwjbTiGPMlt2Md0T9H9JQ==",
< "license": "MIT",
< "optional": true |
|
That's a tough one. But I think I've got it 🤯 The thing is that Electron 40 now comes with Temporal - that's great, but it conflicts with the Temporal polyfill from |
|
Update: ggaabe/rrule-temporal#99 was accepted. It's cool that the maintainer responds so quickly 🙂 But the fix didn't cover everything, so I created a follow up PR: ggaabe/rrule-temporal#101. |
|
I think we wait for the fix, AFAIS we have to wait for a |
9a3bdd6 to
549838f
Compare
…date
- Replace deprecated string-based extends syntax ("stylistic/all") with
stylistic.configs.customize() factory function
- Move commaDangle configuration into customize() options for cleaner config
- Fixes padded-blocks and other style rules being incorrectly applied after
updating @stylistic/eslint-plugin from 5.x to 5.7.1
The string-based extends syntax stopped working with the latest update
when used with defineConfig().
|
ggaabe/rrule-temporal#101 was accepted 🥳 And the tests are working now. I ran Since I also pulled up all the other dependencies, an issue arose with an ESLint plugin. This is a foreshadowing of the new major release (v10) of ESLint. I adjusted the config accordingly. |
|
This is what I love about open source. We discovered an issue in a dependency, fixed it upstream, and now other projects using it will benefit too 😃 |
## Release Notes Thanks to: @angeldeejay, @in-voker, @JHWelch, @khassel, @KristjanESPERANTO, @rejas, @sdetweil >⚠️ This release needs nodejs version >=22.21.1 <23 || >=24 (no change to previous release) [Compare to previous Release v2.34.0](v2.34.0...v2.25.0) >⚠️ We introduced some internal changes with this release, please read [this forum post](https://forum.magicmirror.builders/topic/20138/upcoming-release-april-1-2026-breaking-changes-some-operational-changes) before upgrading! ### [core] - Prepare Release 2.35.0 (#4071) - docs: add security policy and vulnerability reporting guidelines (#4069) - refactor: simplify internal `require()` calls (#4056) - allow environment variables in cors urls (#4033) - fix cors proxy getting binary data (e.g. png, webp) (#4030) - fix: correct secret redaction and optimize loadConfig (#4031) - change loading config.js, allow variables in config.js and try to protect sensitive data (#4029) - remove kioskmode (#4027) - Add dark theme logo (#4026) - move custom.css from css to config (#4020) - move default modules from /modules/default to /defaultmodules (#4019) - update node versions in workflows (#4018) - [core] refactor: extract and centralize HTTP fetcher (#4016) - fix systeminformation not displaying electron version (#4012) - Update node-ical and support it's rrule-temporal changes (#4010) - Change default start scripts from X11 to Wayland (#4011) - refactor: unify favicon for index.html and Electron (#4006) - [core] run systeminformation in subprocess so the info is always displayed (#4002) - set next release dev number (#4000) ### [dependencies] - update dependencies (#4068) - update dependencies incl. electron to v41 (#4058) - chore: upgrade ESLint to v10 and fix newly surfaced issues (#4057) - chore: update ESLint and plugins, simplify config, apply new rules (#4052) - chore: update dependencies + add exports, files, and sideEffects fields to package.json (#4040) - [core] refactor: enable ESLint rule require-await and handle detected issues (#4038) - Update node-ical and other deps (#4025) - chore: update dependencies (#4021) - chore(eslint): migrate from eslint-plugin-vitest to @vitest/eslint-plugin and run rules only on test files (#4014) - Update deps as requested by dependabot (#4008) - update Collaboration.md and dependencies (#4001) ### [logging] - refactor: further logger clean-up (#4050) - Fix Node.js v25 logging prefix and modernize logger (#4049) ### [modules/calendar] - fix(calendar): make showEnd behavior more consistent across time formats (#4059) - test(calendar): fix hardcoded date in event shape test (#4055) - [calendar] refactor: delegate event expansion to node-ical's expandRecurringEvent (#4047) - calendar.js: remove useless hasCalendarURL function (#4028) - fix(calendar): update to node-ical 0.23.1 and fix full-day recurrence lookup (#4013) - fix(calendar): correct day-of-week for full-day recurring events across all timezones (#4004) ### [modules/newsfeed] - fix(newsfeed): fix full article view and add framing check (#4039) - [newsfeed] refactor: migrate to centralized HTTPFetcher (#4023) ### [modules/weather] - fix(weather): fix openmeteo forecast stuck in the past (#4064) - fix(weather): fix weathergov forecast day labels off by one (#4065) - weather: fixes for templates (#4054) - weather: add possibility to override njk's and css (#4051) - Use getDateString in openmeteo (#4046) - [weather] refactor: migrate to server-side providers with centralized HTTPFetcher (#4032) - [weather] feat: add Weather API Provider (#4036) ### [testing] - chore: remove obsolete Jest config and unit test global setup (#4044) - replace template_spec test with config_variables test (#4034) - refactor(clientonly): modernize code structure and add comprehensive tests (#4022) - Switch to undici Agent for HTTPS requests (#4015) - chore: migrate CI workflows to ubuntu-slim for faster startup times (#4007) --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Kristjan ESPERANTO <35647502+KristjanESPERANTO@users.noreply.github.com> Co-authored-by: Bugsounet - Cédric <github@bugsounet.fr> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: sam detweiler <sdetweil@gmail.com> Co-authored-by: Veeck <github@veeck.de> Co-authored-by: veeck <gitkraken@veeck.de> Co-authored-by: Magnus <34011212+MagMar94@users.noreply.github.com> Co-authored-by: Ikko Eltociear Ashimine <eltociear@gmail.com> Co-authored-by: DevIncomin <56730075+Developer-Incoming@users.noreply.github.com> Co-authored-by: Nathan <n8nyoung@gmail.com> Co-authored-by: mixasgr <mixasgr@users.noreply.github.com> Co-authored-by: Savvas Adamtziloglou <savvas-gr@greeklug.gr> Co-authored-by: Konstantinos <geraki@gmail.com> Co-authored-by: OWL4C <124401812+OWL4C@users.noreply.github.com> Co-authored-by: BugHaver <43462320+bughaver@users.noreply.github.com> Co-authored-by: BugHaver <43462320+lsaadeh@users.noreply.github.com> Co-authored-by: Koen Konst <koenspero@gmail.com> Co-authored-by: Koen Konst <c.h.konst@avisi.nl> Co-authored-by: dathbe <github@beffa.us> Co-authored-by: Marcel <m-idler@users.noreply.github.com> Co-authored-by: Kevin G. <crazylegstoo@gmail.com> Co-authored-by: Jboucly <33218155+jboucly@users.noreply.github.com> Co-authored-by: Jboucly <contact@jboucly.fr> Co-authored-by: Jarno <54169345+jarnoml@users.noreply.github.com> Co-authored-by: Jordan Welch <JordanHWelch@gmail.com> Co-authored-by: Blackspirits <blackspirits@gmail.com> Co-authored-by: Samed Ozdemir <samed@xsor.io> Co-authored-by: in-voker <58696565+in-voker@users.noreply.github.com> Co-authored-by: Andrés Vanegas Jiménez <142350+angeldeejay@users.noreply.github.com>
--enable-features=UseOzonePlatformin start electron tests (as we did already inpackage.json)22.21.1, add25.xThis is still a draft PR because most calendar electron tests are not running which is caused by the electron update from
v39.3.0tov40.0.0. Maybe @KristjanESPERANTO has an idea ...